IMN-799 Add scaffold for purpose-platformstate-writer #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient-assertion-validation
…atalog-platformstate-writer-v1
…com/pagopa/interop-be-monorepo into IMN-522_client-assertion-validation
…atalog-platformstate-writer-v1
…lient-assertion-validation
…se-platformstate-writer-scaffold
…atalog-platformstate-writer-v1
shuyec
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
…hub.com/pagopa/interop-be-monorepo into IMN-797_catalog-platformstate-writer-v1
…lient-assertion-validation
…se-platformstate-writer-scaffold
galales
approved these changes
Oct 11, 2024
AsterITA
reviewed
Oct 14, 2024
| } from "pagopa-interop-models"; | ||
| import { config } from "./config/config.js"; | ||
|
|
||
| export const writePlatformPurposeEntry = async ( |
There was a problem hiding this comment.
Since there write, read and delete are almost identical to the ones here would it be beneficial to declare these as generics and move to commons?
There was a problem hiding this comment.
Moving to commons is being planned, but I wouldn't turn those into functions with generics, because it doesn't seem a straightforward operation, considering the differences between those entries.
taglioni-r
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IMN-799
Merge after #956
This pull request is for adding the scaffold of the new
purpose-platformstate-writerpackage.